[mod_python] more info about the segfault bug

Thanks Jeff, this fixed the issue for me.  I'll keep watch on this list
and the new httpd.apache.org list for an official update, and for any
word what the side effects (if any, that change looks fairly harmless on
the surface) this has.

Mike

--
Michael C. Neel
There are only 10 types of people in the world;
those who understand binary and those who don't.

-----Original Message-----
From: mod_python-admin at modpython.org
[mailto:mod_python-admin at modpython.org] On Behalf Of Jeff Davis
Sent: Friday, September 13, 2002 5:37 PM
To: mod_python at modpython.org
Subject: [mod_python] more info about the segfault bug



Patch below. That variable "ext" is not being initialized appearently
(in the 
function python_handler in mod_python.c). So I suppose it's not passing
the 
"if(req->filename)" test, and so the call to apr_pstrcat just passes
garbage 
("ext") to the function. Perhaps we need an "else" safety clause, or 
something? I don't really know what's supposed to be happening there,
but if 
someone does maybe this will help them find the problem.

I will continue to look into the problem, but I'm not all that familiar
with 
writing apache modules.


Regards,
	Jeff

Note: patch is from distributed version to me new one. Disregard my
previous 
patch, which implemented Bryan Mongeau's solution.

--- mod_python.c.old	2002-09-13 13:51:09.000000000 -0700
+++ mod_python.c	2002-09-13 14:28:47.000000000 -0700
@@ -742,7 +742,7 @@
     int result;
     const char * interpreter = NULL;
     PyThreadState *tstate;
-    const char *ext;
+    char *ext = NULL;
     hl_entry *hle = NULL;
     hl_entry *dynhle = NULL;
 

_______________________________________________
Mod_python mailing list
Mod_python at modpython.org
http://www.modpython.org/mailman/listinfo/mod_python