[mod_python] Tiny patch for better apr_stat usage in sendfile

Graham Dumpleton grahamd at dscpl.com.au
Tue Jun 6 11:04:08 EDT 2006

Sergey A. Lipnevich wrote ..
> Hi All,
> I'd like to offer the following patch for 3.2.8's sendfile function that
> asks APR to provide less information about a file (which is beneficial
> on Windows as APR doesn't have to construct POSIX protection flags),
> because the only field in use becomes file size. Incidentally, it also
> allows mod_python (plus Apache 2.2 patch) to work with the following
> tweak for APR 1.2.7 (required for Subversion), under Windows and Apache
> 2.2.2: http://article.gmane.org/gmane.comp.apache.apr.devel/9389/.
> I didn't test the patch on anything but Windows XP. The error I was
> getting with the setup above was "Could not stat file for reading."
> I also have to mention that the whole thing was compiled with VS 2005
> compiler to support Python 2.4, although I think it's not relevant for
> the patch attached.
> I hope all this patch citing is not too confusing :-).

Part of this patch may break UNIX systems. Specifically, when target is a
symbolic link, the size returned will be the length of the filename and
not the size of the target file when SIZE and not NORM is used. Thus
an incorrect amount of data is sent back.

Since I am on holidays I can't check into it any further at the moment.
If your truly believe there is a problem there to be fixed, log an issue
report on JIRA for mod_python to ensure it is addressed later.



More information about the Mod_python mailing list